This page contains an archived post to the Design Forum (formerly called the Flexible Java Forum) made prior to February 25, 2002. If you wish to participate in discussions, please visit the new Artima Forums.

Message:

Simpler code for equals(); please review

Posted by Vijay Varanasi on December 14, 1999 at 1:40 AM

Hi!

The code for equals() in the article ensures that the Object passed as an argument is of the same type as itself by trying a typecast; failure results in a ClassCastException which is caught:

public boolean equals(Object o) {

if (o == null) {
return false;
}

Worker w;
try {
w = (Worker) o;
}
catch (ClassCastException e) {
return false;
}
.
.
.

I saw this simpler code elsewhere:

public boolean equals(Object obj)
{
if (obj != null && (obj instanceof this.getClass()))
{
.
.
.

Is this OK? Or are there any hidden glitches in this that aren't apparent to me?

Thanks,
Vijay

• avoir le code de calcul Mouloud Idiri December 30, 2001 at 7:04 AM (1)
  • fgf sdf December 30, 2001 at 7:06 AM (0)
• null instanceof Object == false Steven Pearson August 14, 2000 at 9:10 AM (0)