This page contains an archived post to the Java Answers Forum made prior to February 25, 2002. If you wish to participate in discussions, please visit the new Artima Forums.

Message:

Opinions

Posted by Matt Gerrans on November 20, 2001 at 5:50 PM

Well, I was going to keep my mouth shut, but since you've solicited opions, I'll give one: it is poor (if not uncommon) coding style to put so many operations in a single line. It doesn't create more optimized code, it is harder to read(especially for beginners) and it is harder to debug. If you try to keep one operation per line, then the exceptions you get are very helpful and specific. If you separated the contents your while() test into a few lines, your problem would immediately reveal itself.

- mfg

> Hiran,

> probably u should change the code to be like this :

>

>     BufferedReader fileIn = new BufferedReader(new FileReader("c:\\test.txt"));
>     String taskNumber;
>     while(!((taskNumber = fileIn.readLine())==null)) {  
>         //some code}
> 

> yup, BufferedReader.readLine() will return null if it reaches end of file, but, when it returns null, u can't call the method equals() because null has no such method ;)

> probably it ends the application completely because of NullPointerException.

> any differing opinions?

• Thnx Hiran November 21, 2001 at 3:55 AM (13)
  • today in the LRT (light rail transit) Chin Loong November 21, 2001 at 6:11 AM (12)
    • Style Matt Gerrans November 21, 2001 at 4:03 PM (11)
      • Stylin' Matt Gerrans November 21, 2001 at 7:30 PM (10)
        • south park Chin Loong November 22, 2001 at 7:07 AM (0)
        • Personal preference Hiran November 22, 2001 at 12:44 AM (8)
          • mine Chin Loong November 22, 2001 at 6:55 AM (7)
            • Im with Hiran on this one Jody Brown November 22, 2001 at 12:49 PM (6)
              • Brace yourself Matt Gerrans November 22, 2001 at 3:10 PM (5)
                • how can I start to learn java? Ying Chen January 26, 2002 at 12:25 AM (0)
                • code formatters Jody Brown November 22, 2001 at 5:14 PM (1)
                  • But.... Hiran November 22, 2001 at 9:45 PM (0)
                • code formatters Jody Brown November 22, 2001 at 5:07 PM (1)
                  • Code Formatter Matt Gerrans November 23, 2001 at 2:32 AM (0)